Feature Request: Crit and Dodge Chances

[Gorbuz]

Greetings.

I think WWNData is a greate tool and database, but it misses some key functionality - I cannot compare my rogue's critical and dodge chances with ones from other people's builds..
AFAIK, there are function GetBlockChance, GetDodgeChance and GetCritChance in WoW Lua API.. It would be great if that feature will be implemented soon..

With best gerards, Gorbuz, 60 NE Rogue, Warsong.

[Gorbuz]

I'm not a lua programmer, but I've tried to add missing functionality.

Changes should be done in file CharacterProfiler.lua

.............
-- line 21: After "WNE_CharProfile_DoScanQuests      = 1;      -- get Quests"
WNE_CharProfile_DoScanCrits       = 1;      -- get Crits
.............
--line 330:  before "if ( WNE_CharProfile_DoScanSkills ) then"
if ( WNE_CharProfile_DoScanCrits ) then
    Profile_AddCrits();
end
.............
--line:808 before "function Profile_AddTalents()"
function Profile_AddCrits()
  WNE_Profile_Print_Method_Trace( "e", "Profile_AddCrits" );
  local lCharProfile        = WNE_CurrentCharacter;
  -- Reset/Initialize
  lCharProfile["Crits"] = {};
  lCharProfile["Crits"]["Block"] = GetBlockChance();
  lCharProfile["Crits"]["Crit"] = GetCritChance();
  lCharProfile["Crits"]["Dodge"] = GetDodgeChance();
  lCharProfile["Crits"]["Parry"] = GetParryChance();
  WNE_Profile_Print_Method_Trace( "x", "Profile_AddCrits" );
end

So, in file wownetexport.lua we see following section

["Crits"] = {
				["Dodge"] = 12.16806697845459,
				["Block"] = 36.42218399047852,
				["Crit"] = "10.08",
				["Parry"] = 1.240000009536743,
			},

It would be great, if WWNData developers accept my idea and add this code (or more gracefull one) will be added to next version and display statistics